[PATCH] Fix GM965 TV out regression

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, May 19, 2012 at 04:52:10PM +1000, Robert Lowery wrote:
> I recently upgraded to ubuntu 12.04 and noticed the TV out no longer works
> with kernel 3.2.0.
> 
> Tracing back through old kernels, I found the last working kernel was 2.6.35.
> 
> Now 4 years ago I fixed a similar issue in the user space intel driver by
> waiting for vblank after writing to the TV_CTL register via
> http://cgit.freedesktop.org/xorg/driver/xf86-video-intel/commit/src/i830_tv.c?id=1142be53eb8d2ee8a9b60ace5d49f0ba27332275
> 
> Low and behold, it appears 2 years later this same issue was reintroduced
> in kernel 2.6.36 and has led to some very unhappy users eg
> https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-intel/+bug/763688
> 
> Could someone please apply the following which I have confirmed re-fixes
> the issue for my TV output via component video connection.

Nice piece of diggin through code! A few minor nitpicks on the patch:
- sob-line is missing (see Documentation/SubmittingPatches)
- are there any other people who have tested this patch? If so, please
  include them in the patch with a

  Tested-by: Name <mail at server>

Rodrigo, can you please check this patch with the docs and maybe quickly
run it?

Thanks, Daniel
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48


[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux