On Wed, 16 May 2012 21:40:12 -0700, Ben Widawsky <ben at bwidawsk.net> wrote: > After Daniel split out this code, I think this makes more sense, and > looks nicer. Also added some comments to help the situation. > > Signed-off-by: Ben Widawsky <ben at bwidawsk.net> The change is an improvement, just looks like it could be simplified... ;-p Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk> -Chris -- Chris Wilson, Intel Open Source Technology Centre