On Sun, May 13, 2012 at 4:16 PM, Chris Wilson <chris at chris-wilson.co.uk> wrote: > Turn a fatal lockup into a merely blank display with lots of shouty > messages. > > v2: Whilst in the area, convert the other BUG_ON into less fatal errors. > In particular, note that we may be called on a PCH platform not using > PLLs, such as Haswell, and so we do not always want to BUG_ON(!pll) I think that we need to keep in mind that we can have Haswell+PPT combination, but I don't know what will happen in this case yet. So I'd suggest adding a: WARN_ON(pll == NULL && !HAS_PCH_LPT(dev)); as well somewhere in the checks. What do you think? -- Eugeni Dodonov
