[PATCH] drm/i915: Convert BUG_ON(!pll->active) and friends to a WARN

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 13 May 2012 22:08:10 +0200, Daniel Vetter <daniel at ffwll.ch> wrote:
> On Sun, May 13, 2012 at 08:16:12PM +0100, Chris Wilson wrote:
> > Turn a fatal lockup into a merely blank display with lots of shouty
> > messages.
> > 
> > v2: Whilst in the area, convert the other BUG_ON into less fatal errors.
> > In particular, note that we may be called on a PCH platform not using
> > PLLs, such as Haswell, and so we do not always want to BUG_ON(!pll)
> > 
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> 
> Ok, I guess you want me to drop v1 of this again. I'll wait for a bit of
> feedback on these two then (and the tested-by from qa on the 2nd one).

Up to you, I thought that the original patch was overshadowed by the
your change request and little reason for it to be split. It would be
good to get QA's tested-by on the second patch at any rate.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux