== Series Details == Series: Introduce memory region concept (including device local memory) (rev2) URL : https://patchwork.freedesktop.org/series/56683/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6f6eb8a214a1 drm/i915: buddy allocator -:29: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #29: new file mode 100644 -:278: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #278: FILE: drivers/gpu/drm/i915/i915_buddy.c:245: +void i915_buddy_free_list(struct i915_buddy_mm *mm, + struct list_head *objects) -:436: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #436: FILE: drivers/gpu/drm/i915/i915_buddy.c:403: + if (buddy && (i915_buddy_block_free(block) && + i915_buddy_block_free(buddy))) -:468: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #468: FILE: drivers/gpu/drm/i915/i915_buddy.h:16: +#define I915_BUDDY_ALLOCATED (1<<10) ^ -:469: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #469: FILE: drivers/gpu/drm/i915/i915_buddy.h:17: +#define I915_BUDDY_FREE (2<<10) ^ -:470: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #470: FILE: drivers/gpu/drm/i915/i915_buddy.h:18: +#define I915_BUDDY_SPLIT (3<<10) ^ total: 0 errors, 1 warnings, 5 checks, 1030 lines checked 9dd43433710a drm/i915: introduce intel_memory_region -:65: CHECK:LINE_SPACING: Please don't use multiple blank lines #65: FILE: drivers/gpu/drm/i915/gem/selftests/huge_pages.c:451: + -:95: ERROR:CODE_INDENT: code indent should use tabs where possible #95: FILE: drivers/gpu/drm/i915/gem/selftests/huge_pages.c:481: +^I^I &obj->memory_region->region.start);$ -:179: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #179: new file mode 100644 -:196: CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #196: FILE: drivers/gpu/drm/i915/intel_memory_region.c:13: +{ + -:278: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #278: FILE: drivers/gpu/drm/i915/intel_memory_region.c:95: + * coalesce if we can. + */ -:437: WARNING:TYPO_SPELLING: 'UKNOWN' may be misspelled - perhaps 'UNKNOWN'? #437: FILE: drivers/gpu/drm/i915/intel_memory_region.h:33: + INTEL_MEMORY_UKNOWN, /* Should be last */ -:446: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'r' may be better as '(r)' to avoid precedence issues #446: FILE: drivers/gpu/drm/i915/intel_memory_region.h:42: +#define MEMORY_TYPE_FROM_REGION(r) (ilog2(r >> INTEL_MEMORY_TYPE_SHIFT)) -:447: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'r' may be better as '(r)' to avoid precedence issues #447: FILE: drivers/gpu/drm/i915/intel_memory_region.h:43: +#define MEMORY_INSTANCE_FROM_REGION(r) (ilog2(r & 0xffff)) -:461: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_memory_region *' should also have an identifier name #461: FILE: drivers/gpu/drm/i915/intel_memory_region.h:57: + int (*init)(struct intel_memory_region *); -:462: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_memory_region *' should also have an identifier name #462: FILE: drivers/gpu/drm/i915/intel_memory_region.h:58: + void (*release)(struct intel_memory_region *); -:464: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_memory_region *' should also have an identifier name #464: FILE: drivers/gpu/drm/i915/intel_memory_region.h:60: + struct drm_i915_gem_object * -:464: WARNING:FUNCTION_ARGUMENTS: function definition argument 'resource_size_t' should also have an identifier name #464: FILE: drivers/gpu/drm/i915/intel_memory_region.h:60: + struct drm_i915_gem_object * -:464: WARNING:FUNCTION_ARGUMENTS: function definition argument 'unsigned int' should also have an identifier name #464: FILE: drivers/gpu/drm/i915/intel_memory_region.h:60: + struct drm_i915_gem_object * -:479: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment #479: FILE: drivers/gpu/drm/i915/intel_memory_region.h:75: + struct mutex mm_lock; -:593: WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'igt_mock_fill', this function's name, in a string #593: FILE: drivers/gpu/drm/i915/selftests/intel_memory_region.c:67: + pr_err("igt_mock_fill failed, space still left in region\n"); total: 1 errors, 9 warnings, 5 checks, 649 lines checked b199239505e9 drm/i915/region: support basic eviction 97c56199279a drm/i915/region: support continuous allocations -:22: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #22: FILE: drivers/gpu/drm/i915/gem/i915_gem_object_types.h:137: +#define I915_BO_ALLOC_CONTIGUOUS (1<<0) ^ total: 0 errors, 0 warnings, 1 checks, 238 lines checked 896ab6f953bb drm/i915/region: support volatile objects -:23: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #23: FILE: drivers/gpu/drm/i915/gem/i915_gem_object_types.h:138: +#define I915_BO_ALLOC_VOLATILE (1<<1) ^ total: 0 errors, 0 warnings, 1 checks, 108 lines checked 158dcac99d23 drm/i915: Add memory region information to device_info 07335c6c968c drm/i915: support creating LMEM objects -:57: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #57: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 171 lines checked 894c2da949ad drm/i915: setup io-mapping for LMEM -:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one total: 0 errors, 1 warnings, 0 checks, 35 lines checked 8784beb8d0cd drm/i915/lmem: support kernel mapping -:113: CHECK:LINE_SPACING: Please don't use multiple blank lines #113: FILE: drivers/gpu/drm/i915/intel_region_lmem.h:9: + -:186: ERROR:CODE_INDENT: code indent should use tabs where possible #186: FILE: drivers/gpu/drm/i915/selftests/intel_memory_region.c:415: +^I^I^I val);$ -:186: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #186: FILE: drivers/gpu/drm/i915/selftests/intel_memory_region.c:415: + pr_err("vaddr[%u]=%u, val=%u\n", dword, vaddr[dword], + val); -:198: ERROR:CODE_INDENT: code indent should use tabs where possible #198: FILE: drivers/gpu/drm/i915/selftests/intel_memory_region.c:427: +^I^I^I val ^ 0xdeadbeaf);$ -:198: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #198: FILE: drivers/gpu/drm/i915/selftests/intel_memory_region.c:427: + pr_err("vaddr[%u]=%u, val=%u\n", dword, vaddr[dword], + val ^ 0xdeadbeaf); total: 2 errors, 0 warnings, 3 checks, 187 lines checked cac31ed0edda drm/i915/blt: support copying objects -:14: ERROR:BAD_SIGN_OFF: Unrecognized email address: 'Abdiel Janulgue <abdiel.janulgue@xxxxxxxxxxxxxxx' #14: Cc: Abdiel Janulgue <abdiel.janulgue@xxxxxxxxxxxxxxx -:38: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV) #38: FILE: drivers/gpu/drm/i915/gem/i915_gem_object_blt.c:119: + *cs++ = GEN9_XY_FAST_COPY_BLT_CMD | (10-2); ^ -:49: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV) #49: FILE: drivers/gpu/drm/i915/gem/i915_gem_object_blt.c:130: + *cs++ = XY_SRC_COPY_BLT_CMD | BLT_WRITE_RGBA | (10-2); ^ -:60: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV) #60: FILE: drivers/gpu/drm/i915/gem/i915_gem_object_blt.c:141: + *cs++ = XY_SRC_COPY_BLT_CMD | BLT_WRITE_RGBA | (8-2); ^ -:193: WARNING:LINE_SPACING: Missing a blank line after declarations #193: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c:103: + struct rnd_state prng; + IGT_TIMEOUT(end); -:308: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #308: FILE: drivers/gpu/drm/i915/gt/intel_gpu_commands.h:185: +#define GEN9_XY_FAST_COPY_BLT_CMD ((2<<29)|(0x42<<22)) ^ -:308: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV) #308: FILE: drivers/gpu/drm/i915/gt/intel_gpu_commands.h:185: +#define GEN9_XY_FAST_COPY_BLT_CMD ((2<<29)|(0x42<<22)) ^ -:308: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #308: FILE: drivers/gpu/drm/i915/gt/intel_gpu_commands.h:185: +#define GEN9_XY_FAST_COPY_BLT_CMD ((2<<29)|(0x42<<22)) ^ -:309: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #309: FILE: drivers/gpu/drm/i915/gt/intel_gpu_commands.h:186: +#define XY_SRC_COPY_BLT_CMD ((2<<29)|(0x53<<22)) ^ -:309: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV) #309: FILE: drivers/gpu/drm/i915/gt/intel_gpu_commands.h:186: +#define XY_SRC_COPY_BLT_CMD ((2<<29)|(0x53<<22)) ^ -:309: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #309: FILE: drivers/gpu/drm/i915/gt/intel_gpu_commands.h:186: +#define XY_SRC_COPY_BLT_CMD ((2<<29)|(0x53<<22)) ^ total: 1 errors, 1 warnings, 9 checks, 277 lines checked 4de58ea97434 drm/i915/selftests: move gpu-write-dw into utils cc31698abc26 drm/i915/selftests: add write-dword test for LMEM -:87: WARNING:LINE_SPACING: Missing a blank line after declarations #87: FILE: drivers/gpu/drm/i915/selftests/intel_memory_region.c:411: + struct intel_engine_cs *engine; + IGT_TIMEOUT(end_time); -:160: WARNING:LINE_SPACING: Missing a blank line after declarations #160: FILE: drivers/gpu/drm/i915/selftests/intel_memory_region.c:498: + struct drm_i915_gem_object *obj; + I915_RND_STATE(prng); total: 0 errors, 2 warnings, 0 checks, 185 lines checked 88e9fcca4054 drm/i915/selftests: don't just test CACHE_NONE for huge-pages 7e21a904a5ac drm/i915/selftest: extend coverage to include LMEM huge-pages -:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one total: 0 errors, 1 warnings, 0 checks, 146 lines checked 6bef737f4655 drm/i915/lmem: support CPU relocations -:85: CHECK:SPACING: No space is necessary after a cast #85: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1091: + io_mapping_unmap_atomic((void __force __iomem *) unmask_page(cache->vaddr)); total: 0 errors, 0 warnings, 1 checks, 100 lines checked 1c5dce2c18de drm/i915/lmem: support pread -:20: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct drm_i915_gem_object *' should also have an identifier name #20: FILE: drivers/gpu/drm/i915/gem/i915_gem_object_types.h:55: + int (*pread)(struct drm_i915_gem_object *, total: 0 errors, 1 warnings, 0 checks, 106 lines checked 282c4317ef1a drm/i915/lmem: support pwrite -:71: ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #71: FILE: drivers/gpu/drm/i915/intel_region_lmem.c:135: + unwritten = copy_from_user((void __force*)vaddr + offset, total: 1 errors, 0 warnings, 0 checks, 87 lines checked c0332db20e13 drm/i915: enumerate and init each supported region eb9166edbaaa drm/i915: treat shmem as a region -:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one -:49: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #49: FILE: drivers/gpu/drm/i915/gem/i915_gem_shmem.c:434: +static int __create_shmem(struct drm_i915_private *i915, struct drm_gem_object *obj, -:61: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #61: FILE: drivers/gpu/drm/i915/gem/i915_gem_shmem.c:457: + unsigned flags) -:123: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 17) #123: FILE: drivers/gpu/drm/i915/gem/i915_gem_shmem.c:579: + if (err) + DRM_NOTE("Unable to create a private tmpfs mount, hugepage support will be disabled(%d).\n", err); -:124: WARNING:LONG_LINE: line over 100 characters #124: FILE: drivers/gpu/drm/i915/gem/i915_gem_shmem.c:580: + DRM_NOTE("Unable to create a private tmpfs mount, hugepage support will be disabled(%d).\n", err); total: 0 errors, 4 warnings, 1 checks, 254 lines checked 3fff0096edab drm/i915: treat stolen as a region 089ac99864c6 drm/i915: define HAS_MAPPABLE_APERTURE -:20: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'dev_priv' may be better as '(dev_priv)' to avoid precedence issues #20: FILE: drivers/gpu/drm/i915/i915_drv.h:2247: +#define HAS_MAPPABLE_APERTURE(dev_priv) (dev_priv->ggtt.mappable_end > 0) total: 0 errors, 0 warnings, 1 checks, 8 lines checked 50a3eeb8189f drm/i915: do not map aperture if it is not available. -:40: CHECK:SPACING: No space is necessary after a cast #40: FILE: drivers/gpu/drm/i915/i915_gem_gtt.c:3394: + (struct resource) DEFINE_RES_MEM(pci_resource_start(pdev, 2), total: 0 errors, 0 warnings, 1 checks, 55 lines checked 3fb004e577d6 drm/i915: expose missing map_gtt support to users 5681ea496f31 drm/i915: set num_fence_regs to 0 if there is no aperture c3ebef177d7d drm/i915/selftests: check for missing aperture 6cef423853ea drm/i915: error capture with no ggtt slot -:162: WARNING:LINE_SPACING: Missing a blank line after declarations #162: FILE: drivers/gpu/drm/i915/i915_gpu_error.c:1782: + const u64 slot = ggtt->error_capture.start; + ggtt->vm.clear_range(&ggtt->vm, slot, PAGE_SIZE); total: 0 errors, 1 warnings, 0 checks, 139 lines checked bf7a75b46b28 drm/i915: Don't try to place HWS in non-existing mappable region c5129ddc06ad drm/i915: Allow i915 to manage the vma offset nodes instead of drm core -:218: ERROR:CODE_INDENT: code indent should use tabs where possible #218: FILE: drivers/gpu/drm/i915/gem/i915_gem_mman.c:605: +^I mmo = container_of(node, struct i915_mmap_offset,$ -:349: ERROR:CODE_INDENT: code indent should use tabs where possible #349: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:131: +^I mmo->vma_node.readonly = true;$ -:391: ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" #391: FILE: drivers/gpu/drm/i915/gem/i915_gem_object_types.h:70: + struct drm_i915_gem_object* obj; total: 3 errors, 0 warnings, 0 checks, 501 lines checked 4981ff369abe drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET -:120: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #120: FILE: include/uapi/drm/i915_drm.h:362: +#define DRM_I915_GEM_MMAP_OFFSET ^IDRM_I915_GEM_MMAP_GTT$ -:128: WARNING:LONG_LINE: line over 100 characters #128: FILE: include/uapi/drm/i915_drm.h:425: +#define DRM_IOCTL_I915_GEM_MMAP_OFFSET DRM_IOWR(DRM_COMMAND_BASE + DRM_I915_GEM_MMAP_OFFSET, struct drm_i915_gem_mmap_offset) total: 0 errors, 2 warnings, 0 checks, 129 lines checked 5cd5c23c7ae8 drm/i915/lmem: add helper to get CPU accessible offset 3a94fa78f237 drm/i915: Add cpu and lmem fault handlers -:53: WARNING:LINE_SPACING: Missing a blank line after declarations #53: FILE: drivers/gpu/drm/i915/gem/i915_gem_mman.c:395: + struct page *page = i915_gem_object_get_page(obj, i); + vmf_ret = vmf_insert_pfn(area, total: 0 errors, 1 warnings, 0 checks, 285 lines checked 8c21fd6a50e8 drm/i915: cpu-map based dumb buffers -:25: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #25: FILE: drivers/gpu/drm/i915/gem/i915_gem_mman.c:604: +i915_gem_mmap_dumb(struct drm_file *file, + struct drm_device *dev, -:90: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #90: FILE: drivers/gpu/drm/i915/i915_drv.h:2517: +int i915_gem_mmap_dumb(struct drm_file *file_priv, struct drm_device *dev, u32 handle, u64 *offset); total: 0 errors, 0 warnings, 2 checks, 56 lines checked 80c18bff8a6f drm/i915: support basic object migration -:77: WARNING:TYPO_SPELLING: 'UKNOWN' may be misspelled - perhaps 'UNKNOWN'? #77: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.c:221: + GEM_BUG_ON(id >= INTEL_MEMORY_UKNOWN); -:269: WARNING:LINE_SPACING: Missing a blank line after declarations #269: FILE: drivers/gpu/drm/i915/selftests/intel_memory_region.c:662: + struct drm_i915_gem_object *obj; + IGT_TIMEOUT(end_time); total: 0 errors, 2 warnings, 0 checks, 312 lines checked d3e6c6c9f2a5 drm/i915: Introduce GEM_OBJECT_SETPARAM with I915_PARAM_MEMORY_REGION -:90: WARNING:TYPO_SPELLING: 'UKNOWN' may be misspelled - perhaps 'UNKNOWN'? #90: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.c:564: + return INTEL_MEMORY_UKNOWN; -:100: WARNING:TYPO_SPELLING: 'UKNOWN' may be misspelled - perhaps 'UNKNOWN'? #100: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.c:574: + u32 uregions_copy[INTEL_MEMORY_UKNOWN]; -:122: ERROR:CODE_INDENT: code indent should use tabs where possible #122: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.c:596: +^I goto err;$ -:132: WARNING:TYPO_SPELLING: 'UKNOWN' may be misspelled - perhaps 'UNKNOWN'? #132: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.c:606: + if (id == INTEL_MEMORY_UKNOWN) { -:168: CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #168: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.c:642: +{ + -:229: WARNING:LONG_LINE: line over 100 characters #229: FILE: include/uapi/drm/i915_drm.h:427: +#define DRM_IOCTL_I915_GEM_OBJECT_SETPARAM DRM_IOWR(DRM_COMMAND_BASE + DRM_I915_GEM_OBJECT_SETPARAM, struct drm_i915_gem_object_param) total: 1 errors, 4 warnings, 1 checks, 221 lines checked 45761cc62ad8 drm/i915/query: Expose memory regions through the query uAPI -:100: CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #100: FILE: include/uapi/drm/i915_drm.h:2185: +struct drm_i915_memory_region_info { + -:127: CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #127: FILE: include/uapi/drm/i915_drm.h:2212: +struct drm_i915_query_memory_region_info { + total: 0 errors, 0 warnings, 2 checks, 118 lines checked f5de7bb8e2d3 HAX drm/i915: add the fake lmem region -:44: WARNING:LONG_LINE_COMMENT: line over 100 characters #44: FILE: drivers/gpu/drm/i915/i915_drv.c:1904: + intel_graphics_fake_lmem_res.end = SZ_2G; /* Placeholder; depends on aperture size */ -:50: WARNING:LONG_LINE: line over 100 characters #50: FILE: drivers/gpu/drm/i915/i915_drv.c:1910: + pr_info("Intel graphics fake LMEM starts at %pa\n", &intel_graphics_fake_lmem_res.start); -:90: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #90: FILE: drivers/gpu/drm/i915/i915_params.c:168: +i915_param_named_unsafe(fake_lmem_start, ulong, 0600, + "Fake LMEM start offset (default: 0)"); total: 0 errors, 2 warnings, 1 checks, 195 lines checked 2c530c39178d HAX drm/i915/lmem: default userspace allocations to LMEM _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
