More focused proposal for display/GT uncore split. A few notes/considerations: - I've copied the MMIO ranges check in patch 3 from a patch from Ville that did something similar in regards to splitting GT/DE register access. I'm seeing some check failures on gen 3 and 4 [1], so I'd appreciate it if someone could double check those ranges since I'm not familiar with those gens. For the same reason I don't expect BAT to pass. - Instead of doing a range check to find erroneous accesses, I considered using a new structure for display registers (wrapping i915_reg_t) and therefore force a compile-time check, but the sheer amount of register definitions that would need updating makes this hard to merge together with the switch to the new functions without hitting conflicts. If there is interest in this option, I'll put something out after all the display register accesses have transitioned to the new accessors. - When MMIO debug is enabled, the accesses from GT and DE are still serialized because the HW debug infrastructure is shared. Since our testing defaults the MMIO debug on, we won't really test parallel accesses. After the series settles down I'm going to submit a CI run with MMIO debug off, but maybe we should update some tests to run with MMIO debug disabled. Thoughts? Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> Cc: Jani Nikula <jani.nikula@xxxxxxxxx> Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxxxxxxx> [1] https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_4491/? Daniele Ceraolo Spurio (4): drm/i915: split out uncore_mmio_debug drm/i915: rework mmio debug stop/start drm/i915: introduce display_uncore drm/i915: convert intel_hdmi to display reg accessors drivers/gpu/drm/i915/display/intel_hdmi.c | 278 ++++++++++------------ drivers/gpu/drm/i915/i915_debugfs.c | 2 +- drivers/gpu/drm/i915/i915_drv.c | 20 +- drivers/gpu/drm/i915/i915_drv.h | 59 +++++ drivers/gpu/drm/i915/intel_uncore.c | 100 +++++--- drivers/gpu/drm/i915/intel_uncore.h | 18 +- 6 files changed, 292 insertions(+), 185 deletions(-) -- 2.20.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
