On Thu, May 10, 2012 at 11:39:49AM +0200, Takashi Iwai wrote: > At Thu, 10 May 2012 10:25:44 +0100, > Chris Wilson wrote: > > > > On Thu, 10 May 2012 11:19:11 +0200, Takashi Iwai <tiwai at suse.de> wrote: > > > At Thu, 10 May 2012 11:06:46 +0200, > > > Daniel Vetter wrote: > > > > This patch is not just for hotplug, but for all the delayed work and timer > > > > stuff the driver does. And we _do_ have a bug report that leaking the rps > > > > work (for snb+ turbo mode) across either a s/r cycle or a gpu reset kills > > > > the driver. > > > > > > Yes, but my point is that Chris's patch (at least the commit above > > > alone) won't fix the problem we faced. > > > > The patch I thought you two were talking about was: > > http://cgit.freedesktop.org/~ickle/linux-2.6/commit/?h=fastboot&id=a5f91dcc3cb7a9dc1214d5014ea6f0338824ad8e > > which is what I thought we had planned to fix the residual issue. > > Thanks, this explains better :) > > But, as far as I checked, the hotplug event wasn't a leftover but > newly triggered during the resume procedure. Thus there is still a > race even with the patch [drm/i915: Cancel outstanding modeset workers > before suspend]. Sorry for the confusion, I've thought the patch I've quoted might fix another bug around s/r, in addition to the hotplug race. -Daniel -- Daniel Vetter Mail: daniel at ffwll.ch Mobile: +41 (0)79 365 57 48
