[PATCH 03/12 v2] drm/i915: move vbetool invoked ier stuff

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 26 Apr 2012 16:03:00 -0700
Ben Widawsky <ben at bwidawsk.net> wrote:

> This extra bit of interrupt enabling code doesn't belong in the wait
> seqno function. If anything we should pull it out to a helper so the
> throttle code can also use it. The history is a bit vague, but I am
> going to attempt to just dump it, unless someone can argue otherwise.
> 
> Removing this allows for a shared lock free wait seqno function. To
> keep tabs on this issue though, the IER value is stored on error
> capture (recommended by Chris Wilson)
> 
> v2: fixed typo EIR->IER (Ben)
> Fix some white space (Ben)
> Move IER capture to globally instead of per ring (Ben)
> 

It may be safe to remove this now.  Distros used to run vbetool at
random times, shutting things off and messing with hw.  But these days
they use the driver with a bit less molestation, so the IER check/fix
shouldn't be needed.

Jesse


[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux