== Series Details == Series: fbcon notifier begone v3! URL : https://patchwork.freedesktop.org/series/61236/ State : warning == Summary == $ dim checkpatch origin/drm-tip cebafaf0747f dummycon: Sprinkle locking checks -:47: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 23 lines checked 5000d1a85eb9 fbdev: locking check for fb_set_suspend -:36: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 8 lines checked 73a9c408d921 vt: might_sleep() annotation for do_blank_screen -:35: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 8 lines checked 2fe968835e01 vt: More locking checks -:73: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 38 lines checked 9045c1cf5f58 fbdev/sa1100fb: Remove dead code -:54: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 35 lines checked fb04604a990f fbdev/cyber2000: Remove struct display -:25: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 7 lines checked a5d036e0043d fbdev/aty128fb: Remove dead code -:90: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 70 lines checked ecb66f11a1ff fbcon: s/struct display/struct fbcon_display/ -:272: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #272: FILE: drivers/video/fbdev/core/fbcon.c:2117: +static void updatescrollmode(struct fbcon_display *p, struct fb_info *info, -:386: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 1 checks, 317 lines checked 6619af25a649 fbcon: Remove fbcon_has_exited -:11: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 6104c37094e7 ("fbcon: Make fbcon a built-time depency for fbdev")' #11: commit 6104c37094e729f3d4ce65797002112735d49cd1 -:47: WARNING:TYPO_SPELLING: 'unecessary' may be misspelled - perhaps 'unnecessary'? #47: v4: Drop unecessary assignment - I forgot to delete the first -:96: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #96: FILE: drivers/video/fbdev/core/fbcon.c:1065: + if (WARN_ON(info_idx == -1)) return; -:206: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 1 errors, 3 warnings, 0 checks, 126 lines checked 9c083d2fe70b fbcon: call fbcon_fb_(un)registered directly -:11: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 6104c37094e7 ("fbcon: Make fbcon a built-time depency for fbdev")' #11: commit 6104c37094e729f3d4ce65797002112735d49cd1 -:157: WARNING:LINE_SPACING: Missing a blank line after declarations #157: FILE: drivers/video/fbdev/core/fbmem.c:1728: + struct fb_event event; + event.info = fb_info; -:192: WARNING:LINE_SPACING: Missing a blank line after declarations #192: FILE: drivers/video/fbdev/core/fbmem.c:1799: + struct fb_event event; + event.info = fb_info; -:239: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 1 errors, 3 warnings, 0 checks, 147 lines checked 4c21aa249801 fbdev/sh_mobile: remove sh_mobile_lcdc_display_notify eb70d4d8e8aa fbdev/omap: sysfs files can't disappear before the device is gone 1584f5ae09d8 fbdev: sysfs files can't disappear before the device is gone af9609593c5c staging/olpc: lock_fb_info can't fail 910c1d3d79d1 fbdev/atyfb: lock_fb_info can't fail 095e29b74dcb fbdev: lock_fb_info cannot fail -:11: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit c47747fde931 ("fbmem: make read/write/ioctl use the frame buffer at open time")' #11: commit c47747fde931c02455683bd00ea43eaa62f35b0e -:309: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 1 errors, 1 warnings, 0 checks, 212 lines checked 7196319b6849 fbcon: call fbcon_fb_bind directly -:162: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 107 lines checked ea0add94a6f8 fbdev: make unregister/unlink functions not fail -:286: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #286: FILE: include/linux/fb.h:637: +extern void unregister_framebuffer(struct fb_info *fb_info); -:287: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #287: FILE: include/linux/fb.h:638: +extern void unlink_framebuffer(struct fb_info *fb_info); -:290: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 2 checks, 226 lines checked 3b19fc0d21c7 fbdev: unify unlink_framebuffer paths -:97: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 63 lines checked 84de4f9c2755 fbdev/sh_mob: Remove fb notifier callback -:21: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 6011bdeaa608 ("fbdev: sh-mobile: HDMI support for SH-Mobile SoCs")' #21: commit 6011bdeaa6089d49c02de69f05980da7bad314ab -:109: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 1 errors, 1 warnings, 0 checks, 62 lines checked 0eaa16d29535 fbdev: directly call fbcon_suspended/resumed -:130: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 77 lines checked b351897540f0 fbcon: Call fbcon_mode_deleted/new_modelist directly -:184: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 123 lines checked e4c80c40a227 fbdev: Call fbcon_get_requirement directly -:120: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 68 lines checked fa63f0d73787 Revert "backlight/fbcon: Add FB_EVENT_CONBLANK" -:138: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 80 lines checked 8941f3518144 fbmem: pull fbcon_fb_blanked out of fb_blank -:89: WARNING:CONSIDER_KSTRTO: simple_strtoul is obsolete, use kstrtoul instead #89: FILE: drivers/video/fbdev/core/fbsysfs.c:311: + arg = simple_strtoul(buf, &last, 0); -:99: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 2 warnings, 0 checks, 40 lines checked c4bd61863f2c fbdev: remove FBINFO_MISC_USEREVENT around fb_blank -:69: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 30 lines checked f73271c8e0e0 fb: Flatten control flow in fb_set_var -:143: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_warn([subsystem]dev, ... then dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ... #143: FILE: drivers/video/fbdev/core/fbmem.c:1027: + printk(KERN_WARNING "detected " -:190: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 2 warnings, 0 checks, 156 lines checked 378342f5ee3d fbcon: replace FB_EVENT_MODE_CHANGE/_ALL with direct calls -:14: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #14: to Maarten for spotting this. So we keep that. We can ditch the differentiation -:62: CHECK:LINE_SPACING: Please don't use multiple blank lines #62: FILE: drivers/video/fbdev/core/fbcon.c:3012: + -:197: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 2 warnings, 1 checks, 121 lines checked ddc3c7ae909a vgaswitcheroo: call fbcon_remap_all directly -:134: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 83 lines checked 95b855ff5fac fbcon: Call con2fb_map functions directly -:89: WARNING:BRACES: braces {} are not necessary for single statement blocks #89: FILE: drivers/video/fbdev/core/fbcon.c:3335: + if (!registered_fb[con2fb.framebuffer]) { + return -EINVAL; } -:239: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 2 warnings, 0 checks, 171 lines checked 6afee4b9c1ce fbcon: Document what I learned about fbcon locking -:45: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 25 lines checked 0f33b49ca081 staging/olpc_dcon: Add drm conversion to TODO -:42: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 11 lines checked 7f004a757694 backlight: simplify lcd notifier -:40: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@xxxxxxxx>' total: 0 errors, 1 warnings, 0 checks, 17 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
