On Sun, 25 Mar 2012 19:47:41 +0200, Daniel Vetter <daniel.vetter at ffwll.ch> wrote: > +/* > + * Multipage variants of the above prefault helpers, useful if more than > + * PAGE_SIZE of date needs to be prefaulted. These are separate from the above s/date/data/ > + * functions (which only handle up to PAGE_SIZE) to avoid clobbering the > + * filemap.c hotpaths. > + */ My only critique is that I'd still like the (a & PAGE_MASK) == (b & PAGE_MASK) to be replaced with a readable macro. #define same_page(a, b) (((unsigned long)(a) & PAGE_MASK) == ((unsigned long)(b) & PAGE_MASK)) -Chris -- Chris Wilson, Intel Open Source Technology Centre
