== Series Details == Series: drm/fb-helper: Move modesetting code to drm_client (rev6) URL : https://patchwork.freedesktop.org/series/58597/ State : warning == Summary == $ dim checkpatch origin/drm-tip 8412c5a47e6f drm/atomic: Move __drm_atomic_helper_disable_plane/set_config() 449ad53787d2 drm/fb-helper: Avoid race with DRM userspace 05a044850b72 drm/fb-helper: No need to cache rotation and sw_rotations a196fbcfb902 drm/fb-helper: Remove drm_fb_helper_crtc->{x, y, desired_mode} e2cdc53e8315 drm/fb-helper: Remove drm_fb_helper_crtc -:123: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #123: new file mode 100644 -:200: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #200: FILE: drivers/gpu/drm/drm_client_modeset.c:73: +} +/* TODO: Remove export when modeset code has been moved over */ -:230: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #230: FILE: drivers/gpu/drm/drm_client_modeset.c:103: +} +/* TODO: Remove export when modeset code has been moved over */ -:924: WARNING:LONG_LINE: line over 100 characters #924: FILE: drivers/gpu/drm/drm_fb_helper.c:2766: + if (WARN_ON_ONCE(modeset->num_connectors == DRM_CLIENT_MAX_CLONED_CONNECTORS || -:925: WARNING:LONG_LINE: line over 100 characters #925: FILE: drivers/gpu/drm/drm_fb_helper.c:2767: + (dev->mode_config.num_crtc > 1 && modeset->num_connectors == 1))) -:1059: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'modeset' - possible side-effects? #1059: FILE: include/drm/drm_client.h:164: +#define drm_client_for_each_modeset(modeset, client) \ + for (({ lockdep_assert_held(&(client)->modeset_mutex); }), \ + modeset = (client)->modesets; modeset->crtc; modeset++) -:1059: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'client' - possible side-effects? #1059: FILE: include/drm/drm_client.h:164: +#define drm_client_for_each_modeset(modeset, client) \ + for (({ lockdep_assert_held(&(client)->modeset_mutex); }), \ + modeset = (client)->modesets; modeset->crtc; modeset++) total: 0 errors, 3 warnings, 4 checks, 958 lines checked ae3299140ceb drm/fb-helper: Prepare to move out commit code 61691a1645f3 drm/fb-helper: Move out commit code -:152: WARNING:LONG_LINE: line over 100 characters #152: FILE: drivers/gpu/drm/drm_client_modeset.c:223: + struct drm_crtc_state *crtc_state = drm_atomic_get_new_crtc_state(state, crtc); -:285: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #285: FILE: drivers/gpu/drm/drm_client_modeset.c:356: + drm_object_property_set_value(&connector->base, + dev->mode_config.dpms_property, dpms_mode); total: 0 errors, 1 warnings, 1 checks, 610 lines checked d699e67d9ac1 drm/fb-helper: Remove drm_fb_helper_connector -:589: WARNING:LONG_LINE: line over 100 characters #589: FILE: drivers/gpu/drm/drm_fb_helper.c:1969: + connector->base.id, connector->tile_group ? connector->tile_group->id : 0); -:946: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #946: FILE: include/drm/drm_client.h:183: +#define drm_client_for_each_connector_iter(connector, iter) \ + drm_for_each_connector_iter(connector, iter) \ + if (connector->connector_type != DRM_MODE_CONNECTOR_WRITEBACK) -:946: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'connector' - possible side-effects? #946: FILE: include/drm/drm_client.h:183: +#define drm_client_for_each_connector_iter(connector, iter) \ + drm_for_each_connector_iter(connector, iter) \ + if (connector->connector_type != DRM_MODE_CONNECTOR_WRITEBACK) total: 1 errors, 1 warnings, 1 checks, 1007 lines checked 455217b5f670 drm/fb-helper: Prepare to move out modeset config code -:169: WARNING:LONG_LINE: line over 100 characters #169: FILE: drivers/gpu/drm/drm_fb_helper.c:2362: + (dev->mode_config.num_crtc > 1 && modeset->num_connectors == 1))) { total: 0 errors, 1 warnings, 0 checks, 179 lines checked 8b19c7eddb5d drm/fb-helper: Move out modeset config code -:99: CHECK:BOOL_COMPARISON: Using comparison to false is error prone #99: FILE: drivers/gpu/drm/drm_client_modeset.c:140: + if (cmdline_mode->specified == false) -:170: WARNING:LONG_LINE: line over 100 characters #170: FILE: drivers/gpu/drm/drm_client_modeset.c:211: + connector->display_info.non_desktop ? "non desktop" : enabled[i] ? "yes" : "no"); -:314: CHECK:BOOL_COMPARISON: Using comparison to false is error prone #314: FILE: drivers/gpu/drm/drm_client_modeset.c:355: + if (enabled[i] == false) { -:348: WARNING:LONG_LINE: line over 100 characters #348: FILE: drivers/gpu/drm/drm_client_modeset.c:389: + connector->base.id, connector->tile_group ? connector->tile_group->id : 0); -:404: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!modes[n]" #404: FILE: drivers/gpu/drm/drm_client_modeset.c:445: + if (modes[n] == NULL) -:736: WARNING:LONG_LINE: line over 100 characters #736: FILE: drivers/gpu/drm/drm_client_modeset.c:777: + if (WARN_ON_ONCE(modeset->num_connectors == DRM_CLIENT_MAX_CLONED_CONNECTORS || -:737: WARNING:LONG_LINE: line over 100 characters #737: FILE: drivers/gpu/drm/drm_client_modeset.c:778: + (dev->mode_config.num_crtc > 1 && modeset->num_connectors == 1))) { -:1496: WARNING:LONG_LINE: line over 100 characters #1496: FILE: include/drm/drm_client.h:155: +int drm_client_modeset_probe(struct drm_client_dev *client, unsigned int width, unsigned int height); total: 0 errors, 5 warnings, 3 checks, 1465 lines checked 8cff9bd3b41e drm/client: Hack: Add bootsplash example -:30: WARNING:CONFIG_DESCRIPTION: please write a paragraph that describes the config symbol fully #30: FILE: drivers/gpu/drm/Kconfig:68: +config DRM_CLIENT_BOOTSPLASH -:51: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 -:56: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #56: FILE: drivers/gpu/drm/drm_bootsplash.c:1: +/* DRM internal client example */ -:82: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment #82: FILE: drivers/gpu/drm/drm_bootsplash.c:27: + struct mutex lock; -:120: WARNING:LONG_LINE: line over 100 characters #120: FILE: drivers/gpu/drm/drm_bootsplash.c:65: + splash->buffers[i] = drm_client_framebuffer_create(&splash->client, width, height, DRM_FORMAT_XRGB8888); -:268: WARNING:LONG_LINE: line over 100 characters #268: FILE: drivers/gpu/drm/drm_bootsplash.c:213: +static int drm_bootsplash_draw(struct drm_bootsplash *splash, unsigned int sequence, unsigned int buffer_num) total: 0 errors, 5 warnings, 1 checks, 412 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
