Hi Chris, Given that you're about the only other gen2 user I know ... can you ack this patch for inclusion into 3.5? Thanks, Daniel On Fri, Mar 02, 2012 at 07:38:30PM +0100, Daniel Vetter wrote: > With the recent set of gmbus fixes, this seems to work on my i855gm. > > Signed-Off-by: Daniel Vetter <daniel.vetter at ffwll.ch> > --- > drivers/gpu/drm/i915/intel_i2c.c | 4 ---- > 1 files changed, 0 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_i2c.c b/drivers/gpu/drm/i915/intel_i2c.c > index 601c86e..8f66397 100644 > --- a/drivers/gpu/drm/i915/intel_i2c.c > +++ b/drivers/gpu/drm/i915/intel_i2c.c > @@ -388,10 +388,6 @@ int intel_setup_gmbus(struct drm_device *dev) > bus->reg0 = i | GMBUS_RATE_100KHZ; > > bus->has_gpio = intel_gpio_setup(bus, i); > - > - /* XXX force bit banging until GMBUS is fully debugged */ > - if (bus->has_gpio && IS_GEN2(dev)) > - bus->force_bit = true; > } > > intel_i2c_reset(dev_priv->dev); > -- > 1.7.8.3 > -- Daniel Vetter Mail: daniel at ffwll.ch Mobile: +41 (0)79 365 57 48