On Fri, 23 Mar 2012 23:43:35 +0100, Daniel Vetter <daniel.vetter at ffwll.ch> wrote: > With valleyview we'll have these at yet another address, so keeping > track of this with an ever-growing list of registers will get ugly. > > This way intel_sdvo.c is fully independent of the base address of the > output ports display register blocks. > > While at it, do 2 closely related cleanups: > - use SDVO_NAME some more > - change the sdvo_reg variables to uint32_t like other registers. > > Signed-Off-by: Daniel Vetter <daniel.vetter at ffwll.ch> Not much to say, removing the duplication of SDVO_NAME is nice. Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk> -Chris -- Chris Wilson, Intel Open Source Technology Centre