On Thu, Mar 22, 2012 at 09:18:32AM -0300, Eugeni Dodonov wrote: > On Thu, Mar 22, 2012 at 07:43, Chris Wilson <chris at chris-wilson.co.uk>wrote: > > > On Wed, 21 Mar 2012 22:09:42 -0300, Eugeni Dodonov < > > eugeni.dodonov at intel.com> wrote: > > > This is one set of those registers for each pipe. > > > Would these not benefit from a #define DP_TP_CTL(pipe)? > > > > Sorry, my typo went in - there is one set of those registers for each > *port*. I defined DP_TP_CTL(pipe) for this (and all other DP_TP_* ones), > but in the end I figured out that pipes need to be programmed independently > from ports. Hm, so maybe it's time to add an enum ports as Chris suggested? Or is that stuff to different on the different platforms to make sense? -Daniel -- Daniel Vetter Mail: daniel at ffwll.ch Mobile: +41 (0)79 365 57 48
