On Wed, 21 Mar 2012 13:53:12 -0700
Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
> On Wed, 21 Mar 2012 17:44:12 -0300
> Eugeni Dodonov <eugeni at dodonov.net> wrote:
>
> > On Wed, Mar 21, 2012 at 16:48, Jesse Barnes
> > <jbarnes at virtuousgeek.org>wrote:
> >
> > > + } else {
> >
> > + DRM_DEBUG_KMS("failed to fetch edid\n");
> > > }
> > >
> >
> >
> > Wouldn't it be prettier if we also add some:
> > ...
> > err = -ENXIO;
> >
> > or similar error in that block, to let the caller know that we
> > failed as well?
> >
> >
> > > return ret;
> > >
> >
>
> Maybe but I think most callers just check for the EDID later anyway.
>
> Really this patch can be dropped, but I was wondering exactly where
> the GPIO side of things was failing and added some debug output...
>
I guess it's not exactly an error if no modes were gotten, so
returning 0 seems right (and initially confusing to me as well). Can you
add some information about the connector and/or adapter. Otherwise I
don't think this is very helpful.
