Ville: Yes, if this patch is needed by kernel 3.10.61, please get somebody to review it. What do I need do to speed up the review process? Please generate a patch against kernel 3.10.61 if possible. Thanks, Jim Caterpillar: Confidential Green -----Original Message----- From: Jim Zhang Sent: Tuesday, April 9, 2019 10:18 AM To: 'Ville Syrjälä' <ville.syrjala@xxxxxxxxxxxxxxx> Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx Subject: RE: colorkey support for intel i915 gpu driver If I go with pre-configured colorkey, do I need port your kernel patch to i915 driver at kernel 3.10.61 ? Thanks, Jim Caterpillar: Confidential Green -----Original Message----- From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> Sent: Tuesday, April 9, 2019 10:02 AM To: Jim Zhang <Zhang_Jim@xxxxxxx> Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx Subject: Re: colorkey support for intel i915 gpu driver On Tue, Apr 09, 2019 at 02:24:03PM +0000, Jim Zhang wrote: > What about if I disable interrupt when changing the colorkey? This > will solve the atomic issue. I think we only change colorkey or > enable/disable colorkey once a while. If disabling interrupt work, I > will disable interrupt and change colorkey. That performance affection > could be acceptable Interrupts don't matter for this. > > Thanks > > Jim > > Caterpillar: Confidential Green > > -----Original Message----- > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > Sent: Tuesday, April 9, 2019 9:19 AM > To: Jim Zhang <Zhang_Jim@xxxxxxx> > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx > Subject: Re: colorkey support for intel i915 gpu driver > > On Tue, Apr 09, 2019 at 02:14:49PM +0000, Jim Zhang wrote: > > Once I pre-configure the colorkey, am I able to enable and disable it? > > If colorkey can be enabled/disabled after that might meet my > > requirement > > Not atomically with other updates. > > > > > Thanks, > > > > Jim > > > > > > Caterpillar: Confidential Green > > > > -----Original Message----- > > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > Sent: Tuesday, April 9, 2019 8:57 AM > > To: Jim Zhang <Zhang_Jim@xxxxxxx> > > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx > > Subject: Re: colorkey support for intel i915 gpu driver > > > > On Tue, Apr 09, 2019 at 04:46:24PM +0300, Ville Syrjälä wrote: > > > On Tue, Apr 09, 2019 at 01:29:41PM +0000, Jim Zhang wrote: > > > > Villie: > > > > > > > > What is Intel's plan for the colorkey patch? Does Intel have any plan to review and release? > > > > > > There is no real plan at this time. But if you have a use case for > > > it I can try to harass people until someone reviews it :) > > > > > > > If I go with custom ioctl, and my custom ioctl will only used in Baytrail product, could it be atomic for Baytrail only? > > > > > > No. We would need to define a new api for it. > > > > I should clarify that you can pre-configure the colorkey before turning on the sprite plane(s). So unless you really need to change the colorkey while the sprite plane(s) are already enabled you may not even need an atomic api for this. > > > > > > > > > > > > > Thanks, > > > > > > > > Jim > > > > > > > > > > > > Caterpillar: Confidential Green > > > > > > > > -----Original Message----- > > > > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > > > Sent: Tuesday, April 2, 2019 7:32 AM > > > > To: Jim Zhang <Zhang_Jim@xxxxxxx> > > > > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx; > > > > intel-gfx@xxxxxxxxxxxxxxxxxxxxx > > > > Subject: Re: colorkey support for intel i915 gpu driver > > > > > > > > On Mon, Apr 01, 2019 at 08:18:13PM +0000, Jim Zhang wrote: > > > > > Hi Sir/Madam: > > > > > > > > > > I am using the open source Baytrail gpu drm driver. > > > > > > > > > > Linux kernel version 3.10.61: > > > > > Libdrm package: 2.4.97 > > > > > > > > > > When calling function > > > > > properties = drmModeObjectGetProperties(drmfd, plane_id, > > > > > DRM_MODE_OBJECT_PLANE); it only returns only one property: > > > > > > > > > > This property is: > > > > > property->name = "rotation", property->prop_id =4 It looks > > > > > like that the Baytrail gpu drm driver does not support colorkey. > > > > > > > > There are two problems currently: > > > > - Destination colorkey is not implemented on BYT/CHV. I have > > > > patches for it but they have not been reviewed by anyone: > > > > > > > > https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.f > > > > re > > > > ed > > > > esktop.org_series_43902_&d=DwIDAw&c=p0oa49nxxGtbbM2qgM-GB4r4m9Ol > > > > Gg > > > > -s > > > > Ep8sXylY2aQ&r=kszNssoSc2KF2GeTYwo7za6kdvLoemctuEIYtXbA4PI&m=ztfg > > > > UC > > > > y9 > > > > ePzHa0zagoDF75AfJJVbElfjXUWmbpBRM58&s=aXK10RLMgC4i_nBRGS6Jzzbv3p > > > > Xo > > > > 50 > > > > PX79myDO5gEYA&e= > > > > - Colorkey can only be set via a custom i915 specific ioctl > > > > (DRM_I915_SET_SPRITE_COLORKEY). There have been a few attempts at > > > > a generic property based API that never really went anywhere. It's > > > > a rather difficult problem making this generic as each hardware has > > > > its own peculiar way of specifying colorkeying. The main problem > > > > with the custom ioctl is that it's not atomic with other screen > > > > updates. > > > > > > > > So, what kind of use case do you have in mind? > > > > > > > > -- > > > > Ville Syrjälä > > > > Intel > > > > > > -- > > > Ville Syrjälä > > > Intel > > > _______________________________________________ > > > Intel-gfx mailing list > > > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > > > https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.freedes > > > kt > > > op > > > .org_mailman_listinfo_intel-2Dgfx&d=DwIDAw&c=p0oa49nxxGtbbM2qgM-GB > > > 4r > > > 4m > > > 9OlGg-sEp8sXylY2aQ&r=kszNssoSc2KF2GeTYwo7za6kdvLoemctuEIYtXbA4PI&m > > > =O > > > yn > > > sqGRzmnTMX2pxog1nBd_nnCa413-CM6loSIjLXXo&s=fjXVFmFDB_LEKe_W5PHzmzk > > > zN > > > PQ > > > cu3xTPSCqb5Dnpwk&e= > > > > -- > > Ville Syrjälä > > Intel > > -- > Ville Syrjälä > Intel -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
