On Fri, Feb 24, 2012 at 09:30:33PM +0000, Chris Wilson wrote: > On Fri, 24 Feb 2012 21:13:41 +0000, Chris Wilson <chris at chris-wilson.co.uk> wrote: > > The use of the mm_list by deferred-free breaks the following patches to > > extend the range of objects tracked. We can simplify things if we just > > make the unbind during free uninterrible. > > Darn it, this *was* two patches before I fluffed the rebase. I haven't looked much at the patch, but the deferred-free looks more bogus the more I stare at it. As long as an object is active, we /should/ have a reference on it, so we should never fail to wait for outstanding rendering on the final free. The only execption is the ilk/vt-d unbind w/a, but that one is already uninterruptible. So I think we should just drop the deferred free list, check for any errors from unbind with a WARN_ON and bail out (leaking the bo) in that case. -Daniel -- Daniel Vetter Mail: daniel at ffwll.ch Mobile: +41 (0)79 365 57 48
