On Sun, Mar 18, 2012 at 2:09 PM, Daniel Vetter <daniel at ffwll.ch> wrote: > On Fri, Mar 16, 2012 at 12:43:21PM -0400, Sean Paul wrote: >> I have experienced a number of NULL pointer dereferences on >> suspend/resume where ring->private is NULL. These come from failed >> initialization of the ring buffer. Sincce this doesn't seem to be easily >> recoverable, this patch adds a BUG_ON and a bread crumb pointer for >> people who might encounter this in the future. >> >> Signed-off-by: Sean Paul <seanpaul at chromium.org> > Chris shot this down on irc, BUG_ON isn't really more useful than a NULL > pointer oops. I agree, so I've dropped this from -next. Yep, makes sense, I agree. Thanks for the explanation. Sean > -Daniel > -- > Daniel Vetter > Mail: daniel at ffwll.ch > Mobile: +41 (0)79 365 57 48
