Re: [PATCH 1/2] drm/i915/ehl: Add EHL platform info and PCI IDs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2019-03-15 at 12:19 -0700, Rodrigo Vivi wrote:
> From: James Ausmus <james.ausmus@xxxxxxxxx>
> 
> Add known EHL PCI IDs.
> 
> v2 (Rodrigo): Removed x86 early quirk. To be sent in a separated
>    	      patch cc'ing the appropriated list and maintainers for
> 	      proper ack.
> v3: (Rodrigo): - Removed .num_pipes = 3 that is coming since
> GEN&_FEATURES.
>     	       - Added ppgtt type and size after rework from Bob and
> Chris
> 
> Cc: Bob Paauwe <bob.j.paauwe@xxxxxxxxx>
> Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Cc: José Roberto de Souza <jose.souza@xxxxxxxxx>
> Signed-off-by: James Ausmus <james.ausmus@xxxxxxxxx>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>
> ---
>  drivers/gpu/drm/i915/i915_pci.c | 10 ++++++++++
>  include/drm/i915_pciids.h       |  7 +++++++
>  2 files changed, 17 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/i915_pci.c
> b/drivers/gpu/drm/i915/i915_pci.c
> index ef7410c492fd..aa26a2e9a466 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -730,6 +730,15 @@ static const struct intel_device_info
> intel_icelake_11_info = {
>  		BIT(RCS0) | BIT(BCS0) | BIT(VECS0) | BIT(VCS0) |
> BIT(VCS2),
>  };
>  
> +static const struct intel_device_info intel_elkhartlake_info = {
> +	GEN11_FEATURES,
> +	PLATFORM(INTEL_ICELAKE),
> +	.is_alpha_support = 1,
> +	.engine_mask = BIT(RCS0) | BIT(BCS0) | BIT(VCS0),
> +	.ppgtt_type = INTEL_PPGTT_FULL,

Nit: You don't need to ppgtt_type it will come from GEN8.

Other than that:
Reviewed-by: José Roberto de Souza <jose.souza@xxxxxxxxx>

> +	.ppgtt_size = 36,
> +};
> +
>  #undef GEN
>  #undef PLATFORM
>  
> @@ -797,6 +806,7 @@ static const struct pci_device_id pciidlist[] = {
>  	INTEL_WHL_U_GT3_IDS(&intel_coffeelake_gt3_info),
>  	INTEL_CNL_IDS(&intel_cannonlake_info),
>  	INTEL_ICL_11_IDS(&intel_icelake_11_info),
> +	INTEL_EHL_IDS(&intel_elkhartlake_info),
>  	{0, 0, 0}
>  };
>  MODULE_DEVICE_TABLE(pci, pciidlist);
> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> index d200000feeaa..a0e409e9e70d 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -472,4 +472,11 @@
>  	INTEL_VGA_DEVICE(0x8A70, info), \
>  	INTEL_VGA_DEVICE(0x8A53, info)
>  
> +/* EHL */
> +#define INTEL_EHL_IDS(info) \
> +	INTEL_VGA_DEVICE(0x4500, info),	\
> +	INTEL_VGA_DEVICE(0x4571, info), \
> +	INTEL_VGA_DEVICE(0x4551, info), \
> +	INTEL_VGA_DEVICE(0x4541, info)
> +
>  #endif /* _I915_PCIIDS_H */

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux