Am Sonntag, den 17.06.2012, 20:36 +0200 schrieb Daniel Vetter:
> On Sun, Jun 17, 2012 at 08:07:15PM +0200, Thomas Richter wrote:
> > On 17.06.2012 14:28, Paul Menzel wrote:
> > >thank you for your patch and patience.
> >
> > >Since this patch is not only a resend but also an improvement please
> > >mark it with ?[PATCH vX]? where X is the iteration next time.
> > >
> > >Also your patch is not created with the Git tool and therefore (not
> > >necessarily) misses some required things as the Signed-off-by line and a
> > >proper commit message (summary and body).
> >
> > Actually, it was created by "git diff HEAD". (-; Anyhow, how do I
> > need to submit it so it gets accepted (or to make this at least
> > easier?)
*Before* creating the patch you have to commit your changes.
git commit -a -s
`-s` adds your Signed-off-by line automatically. You can configure your
data with the following commands.
git config --global user.name "Thomas Richter"
git config --global user.email thor at math.tu-berlin.de
For the commit message give a summary with less than 72 characters, add
a blank line and give an elaborate explanation.
> git format-patch -1 HEAD
For patch iterations do the following.
git format-patch --subject-prefix="PATCH v2" -1 HEAD
The manual pages are pretty elaborate (`git help format-patch`).
`git send-email` can also send the patch for you.
> > >Using these tools also makes the life for the other developers easier
> > >although it might take you some time in the beginning.
> >
> > All understood - please provide some advice.
>
> Imo you don't need anything else, the only other thing missing is the
> signed-off-by line, see Documentation/SubmittingPatches.
As written above `-s` adds that automatically.
Thanks,
Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20120617/d2771143/attachment.pgp>
