On 06/13/2012 04:47 PM, Chris Wilson wrote: > On Wed, 13 Jun 2012 12:07:19 -0700, Ben Widawsky <ben at bwidawsk.net> wrote: >> On Wed, 13 Jun 2012 18:29:51 +0100 >> Chris Wilson <chris at chris-wilson.co.uk> wrote: >> >>> Tidy up the routines for interacting with the GT (in particular the >>> forcewake dance) which are scattered throughout the code in a single >>> structure. >> >> A few comments inline. First though, the bikeshed: >> >> I'd really rather the structure not be named, "gt" unless you have >> further reaching plans for it. GT is way to generic. Also, I think it >> makes a lot of sense to move the forcewake dancing into intel_pm.c > > This patch predated the intel_pm split. I toyed with the idea of > updating it, but preferred to get feedback first. Shall we call it > grantsdale instead? Or uncore? My opinion is that this more core > functionality than power-management, but first and foremost it > should not be scattered across multiple files. I liked the idea of 'gt' because this is how the docs call it too. And our power code is hidden all around indeed. So I'd vote for this patch once it gets updated to intel_pm. I'll even volunteer myself to adjust the power wells and new force wake stuff to it when it becomes ready :). Eugeni
