== Series Details == Series: CRTC background color (rev7) URL : https://patchwork.freedesktop.org/series/50834/ State : warning == Summary == $ dim checkpatch origin/drm-tip db7e455099da drm: Add CRTC background color property (v5) -:239: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'shift' - possible side-effects? #239: FILE: include/uapi/drm/drm_mode.h:931: +#define DRM_ARGB_COMP(c, shift, numbits) \ + (__u16)(((c) & 0xFFFFull << (shift)) >> ((shift) + 16 - (numbits))) total: 0 errors, 0 warnings, 1 checks, 146 lines checked cc27a4184d81 drm/i915/gen9+: Add support for pipe background color (v6) 7ba199d8432b drm/i915: Add background color hardware readout and state check -:66: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'name' - possible side-effects? #66: FILE: drivers/gpu/drm/i915/intel_display.c:11960: +#define PIPE_CONF_CHECK_LLX_MASKED(name, mask) do { \ + if ((current_config->name & mask) != (pipe_config->name & mask)) { \ + pipe_config_err(adjust, __stringify(name), \ + "(expected 0x%016llx, found 0x%016llx)\n", \ + current_config->name & mask, \ + pipe_config->name & mask); \ + ret = false; \ + } \ +} while (0) -:66: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'name' may be better as '(name)' to avoid precedence issues #66: FILE: drivers/gpu/drm/i915/intel_display.c:11960: +#define PIPE_CONF_CHECK_LLX_MASKED(name, mask) do { \ + if ((current_config->name & mask) != (pipe_config->name & mask)) { \ + pipe_config_err(adjust, __stringify(name), \ + "(expected 0x%016llx, found 0x%016llx)\n", \ + current_config->name & mask, \ + pipe_config->name & mask); \ + ret = false; \ + } \ +} while (0) -:66: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'mask' - possible side-effects? #66: FILE: drivers/gpu/drm/i915/intel_display.c:11960: +#define PIPE_CONF_CHECK_LLX_MASKED(name, mask) do { \ + if ((current_config->name & mask) != (pipe_config->name & mask)) { \ + pipe_config_err(adjust, __stringify(name), \ + "(expected 0x%016llx, found 0x%016llx)\n", \ + current_config->name & mask, \ + pipe_config->name & mask); \ + ret = false; \ + } \ +} while (0) -:66: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'mask' may be better as '(mask)' to avoid precedence issues #66: FILE: drivers/gpu/drm/i915/intel_display.c:11960: +#define PIPE_CONF_CHECK_LLX_MASKED(name, mask) do { \ + if ((current_config->name & mask) != (pipe_config->name & mask)) { \ + pipe_config_err(adjust, __stringify(name), \ + "(expected 0x%016llx, found 0x%016llx)\n", \ + current_config->name & mask, \ + pipe_config->name & mask); \ + ret = false; \ + } \ +} while (0) total: 0 errors, 0 warnings, 4 checks, 62 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
