On Tue, 12 Jun 2012 12:02:47 +0200, Daniel Vetter <daniel.vetter at ffwll.ch> wrote: > At least not in the detect function. We'd need eDP vdd to do so if the > panel is off, but I've figured just disabling it is easier. > > This issue has been introduce in > > commit 0d198328538276c4459ef5de081e68ae60e6c4c2 > Author: Adam Jackson <ajax at redhat.com> > Date: Mon May 14 16:05:47 2012 -0400 > > drm/i915/dp: Probe branch/sink OUIs > > Cc: Adam Jackson <ajax at redhat.com> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=50808 > Reported-by: Linus Torvalds <torvalds at linux-foundation.org> > Bugreport: http://permalink.gmane.org/gmane.comp.video.dri.devel/69695 > Tested-by: Yang Guang <guang.a.yang at intel.com> > Signed-Off-by: Daniel Vetter <daniel.vetter at ffwll.ch> > --- > drivers/gpu/drm/i915/intel_dp.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c > index 296cfc2..34e1769 100644 > --- a/drivers/gpu/drm/i915/intel_dp.c > +++ b/drivers/gpu/drm/i915/intel_dp.c > @@ -1970,6 +1970,9 @@ intel_dp_probe_oui(struct intel_dp *intel_dp) > { > u8 buf[3]; > > + if (is_edp(intel_dp)) > + return; Can I be annoying and ask this be annotated that we bail here for convenience and not due to lack of hw support? Otherwise we just add a moment of confusion should we ever need to log oui for eDP. (If manufacturers thought eDP -> LVDS dongles were a good idea, just imagine the chain in a couple of years time...) -Chris -- Chris Wilson, Intel Open Source Technology Centre
