On 06/05/2012 03:52 PM, Eugeni Dodonov wrote: > On 06/05/2012 05:56 AM, Daniel Vetter wrote: >> On Wed, May 23, 2012 at 02:02:00PM +0200, Daniel Vetter wrote: >>> Or at least plug another gapping hole. Apparrently hw desingers only >>> moved the bit field, but did not bother ot re-enumerate the planes >>> when adding support for a 3rd pipe. >>> >>> Discovered by i-g-t/flip_test. >>> >>> This may or may not fix the reference bugzilla, because that one >>> smells like we have still larger fish to fry. >>> >>> v2: Fixup the impossible case to catch programming errors, noticed by >>> Chris Wilson. >>> >>> References: https://bugs.freedesktop.org/show_bug.cgi?id=50069 >>> Signed-Off-by: Daniel Vetter<daniel.vetter at ffwll.ch> >> >> Ping for review and maybe a tested-by. This fixes >> i-g-t/tests/flip_test on >> my ivb, but for some strange reasons QA can't confirm that. Still, I'd >> like to push this patch to -fixes. Eugeni, Ben? > > Although I don't get exact symptoms (I don't get any BUG in dmesg), > without this patch the flip_test hangs when running on 3rd pipe, and > with this patch it proceeds and finishes correctly. > > So this patch fixes this test case, and as far I can see it is correct. > > Tested-by: Eugeni Dodonov <eugeni.dodonov at intel.com> ..and also Reviewed-by: Eugeni Dodonov <eugeni.dodonov at intel.com>
