On Mon, 4 Jun 2012 11:16:04 +0200, Daniel Vetter <daniel at ffwll.ch> wrote: > On Mon, Jun 04, 2012 at 12:04:41PM +0300, Jani Nikula wrote: > > > > Hi Daniel, please find a couple of comments inline. > > Oops, a clear case of -ENOTENOUGHCOFFEE. Thanks for catching these, I'll > follow up with a v2 shortly. Fwiw, the w/a looks harmless and is indeed advisable in cases where we do a lot of writes (which does not really seem to apply here!) Acked-by: Chris Wilson <chris at chris-wilson.co.uk> -Chris -- Chris Wilson, Intel Open Source Technology Centre