On Tue, Nov 13, 2018 at 07:23:30PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > SKL+ do not use crtc_state->update_wm_pre, so there is absolutely no > point it setting it. crtc_state->update_wm_pre only exists as a > temporary hack for pre-g4x platforms until we redo their > watermarks to be be atomic. > > Cc: Stanislav Lisovskiy <stanislav.lisovskiy@xxxxxxxxx> > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> > --- > drivers/gpu/drm/i915/intel_pm.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > index 5d823bdc63a9..9801412062cc 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -5473,12 +5473,6 @@ skl_compute_wm(struct drm_atomic_state *state) > > if (changed) > results->dirty_pipes |= drm_crtc_mask(crtc); > - > - if ((results->dirty_pipes & drm_crtc_mask(crtc)) == 0) > - /* This pipe's WM's did not change */ > - continue; > - > - intel_cstate->update_wm_pre = true; > } > > skl_print_wm_changes(state); > -- > 2.18.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
