If panel supports DRRS and PSR and if driver is loaded without PSR enabled, driver will enable DRRS as expected but if PSR is enabled by debugfs latter it will keep PSR and DRRS enabled causing possible problems as DRRS will lower the refresh rate while PSR enabled. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108341 Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@xxxxxxxxx> Signed-off-by: José Roberto de Souza <jose.souza@xxxxxxxxx> --- drivers/gpu/drm/i915/intel_psr.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c index 853e3f1370a0..bfc6a08b5cf4 100644 --- a/drivers/gpu/drm/i915/intel_psr.c +++ b/drivers/gpu/drm/i915/intel_psr.c @@ -904,8 +904,11 @@ int intel_psr_set_debugfs_mode(struct drm_i915_private *dev_priv, intel_psr_irq_control(dev_priv, dev_priv->psr.debug); - if (dev_priv->psr.prepared && enable) + if (dev_priv->psr.prepared && enable) { + if (crtc_state) + intel_edp_drrs_disable(dp, crtc_state); intel_psr_enable_locked(dev_priv, crtc_state); + } mutex_unlock(&dev_priv->psr.lock); return ret; -- 2.19.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx