On Thu, 05 Jul 2012 14:57:41 -0700, Eric Anholt <eric at anholt.net> wrote: > Chris Wilson <chris at chris-wilson.co.uk> writes: > > > It never quite worked despite the numerous workarounds, yet I still see > > people trying to use this hardware and filing bug reports. As we no > > longer even try to implement the workarounds, since 6a233c78878 > > (drm/i915/ringbuffer: kill snb blt workaround), simply disable the ring. > > Do we have something elsewhere that's very verbose telling them to get > real hardware? Userland isn't going to do very well when the ring > doesn't work. The DDX already checks for the pre-production hardware and forces the shadow buffer if it detects the broken blitter. We can easily add a message there to remind them to return their SDV and get themselves a real computer. So I had actually forgotten about that check. The only question is then whether that is better in the kernel so that all clients are protected from pathological users, or left in the DDX? -Chris -- Chris Wilson, Intel Open Source Technology Centre
