On Mon, 27 Feb 2012 10:50:49 -0800, Eric Anholt <eric at anholt.net> wrote: > On Fri, 24 Feb 2012 21:13:39 +0000, Chris Wilson <chris at chris-wilson.co.uk> wrote: > > @@ -2923,6 +2914,9 @@ i915_gem_object_set_to_gtt_domain(struct drm_i915_gem_object *obj, bool write) > > old_read_domains, > > old_write_domain); > > > > + /* And bump the LRU for this access */ > > + list_move_tail(&obj->mm_list, &dev_priv->mm.inactive_list); > > I don't think you know that !obj->active here. For example, going to > GTT read of something that was currently active and in the SAMPLER read > domain. You're right, I was thinking the wait_rendering() was unconditional like for set-to-cpu-domain. Oh well, at least we can still benefit from not having to worry about being inactive-but-pinned... -Chris -- Chris Wilson, Intel Open Source Technology Centre
