Quoting Michal Wajdeczko (2018-10-17 17:40:50) > On Wed, 17 Oct 2018 00:46:47 +0200, Daniele Ceraolo Spurio > <daniele.ceraolospurio@xxxxxxxxx> wrote: > > > The ENTER/EXIT_S_STATE actions queue the save/restore operation in GuC > > FW and then return, so waiting on the H2G is not enough to guarantee > > GuC is done. > > When all the processing is done, GuC writes 0 to scratch register 14, > > so we can poll on that. Note that GuC does not ensure that the value > > in the register is different from 0 while the action is in progress > > so we need to take care of that ourselves as well. > > > > v2: improve comment, return early on GuC error and improve error > > message (Michal) > > > > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > > Cc: Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx> > > Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx> > > Acked-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > > --- > > Reviewed-by: Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx> Applied, thanks for the fix and review. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
