Re: [PATCH v4] drm/i915: Remove i915.enable_ppgtt override

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Chris Wilson (2018-09-25 14:48:20)
> Now that we are confident in providing full-ppgtt where supported,
> remove the ability to override the context isolation.
> 
> v2: Remove faked aliasing-ppgtt for testing as it no longer is accepted.
> v3: s/USES/HAS/ to match usage and reject attempts to load the module on
> old GVT-g setups that do not provide support for full-ppgtt.
> 
> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
> Cc: Matthew Auld <matthew.auld@xxxxxxxxx>

<SNIP>

> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -345,7 +345,7 @@ static int i915_getparam_ioctl(struct drm_device *dev, void *data,
>                 value = HAS_WT(dev_priv);
>                 break;
>         case I915_PARAM_HAS_ALIASING_PPGTT:
> -               value = USES_PPGTT(dev_priv);
> +               value = INTEL_PPGTT(dev_priv);
>                 break;

Luckily nobody has decided to renumber the modparam values for the sake
of our uAPI :P

Maybe best to have the values in uapi header and then add a translation
here to avoid such a problem in the future. I'd prefer to limit to just
relying the information of 0 (none), 1 (aliasing) or 2 (full) unless
somebody has slipped in code to userspace that relies on detecting the
48-bits from here instead the right place...

Regards, Joonas
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux