On Thu, 9 Feb 2012 17:15:50 +0100, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> v3: Pimp commit message and make Chris Wilson less grumpy by adding a
> module option.
> +void i915_gem_init_ppgtt(struct drm_device *dev)
> +{
> + drm_i915_private_t *dev_priv = dev->dev_private;
> + uint32_t pd_offset;
> + struct intel_ring_buffer *ring;
> + int i;
> +
> + if (i915_enable_ppgtt && !HAS_ALIASING_PPGTT(dev))
> + return;
> +
This is quite a late check since we have already partitioned the
aperture and run i915_gem_init_aliasing_ppgtt. I think the enable check
should be done earlier and this check reduced to
if (!dev_priv->mm.aliasing_ppgtt)
return;
Bah humbug!
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
