On Tue, Feb 07, 2012 at 11:56:36AM -0800, Eric Anholt wrote: > On Mon, 6 Feb 2012 16:45:00 +0100, Daniel Vetter <daniel at ffwll.ch> wrote: > > On Sat, Feb 04, 2012 at 09:59:57PM +0100, Eric Anholt wrote: > > > On Thu, 2 Feb 2012 09:58:12 +0100, Daniel Vetter <daniel.vetter at ffwll.ch> wrote: > > > It looks to me like you're making the HW always swizzle bit 6 according > > > to 9 or 9/10 in i915_gem_init_swizzling, but you're not performing the > > > software side of swizzling in the !dual channel case. My guess would be > > > that when you take your other DIMM the swizzling for pread/pwrite/swap > > > goes wrong, and that the answer would be to just not look at dimm sizes. > > > > Hm, I'm a bit confused here ... So let me explain how swizzling on gen6+ > > works with this patch: > > Nah, I was the one confused. I missed the early return in init. Makes > sense to me now, and I agree that it should be safe to turn on > regardless, so the only issue might be that we should set swizzles on > more of the time than we actually manage to, which you already noted. > > Reviewed-by: Eric Anholt <eric at anholt.net> Queued for -next, thanks for the review. -Daniel -- Daniel Vetter Mail: daniel at ffwll.ch Mobile: +41 (0)79 365 57 48
