On 02/02/12 00:40, Daniel Vetter wrote: > On Wed, Feb 01, 2012 at 09:30:57PM -0800, Ben Widawsky wrote: > [...] >> I'd also say it's not a bad idea to elaborate the assumption that we >> never have less than 256MB of memory WARN_ON(dimm_c0 + dimm_c1 == 0). > > I'm pretty sure that we can't boot with 0mb of ram ;-) The other thing is > that swizzling is a pure preformance optimization - if we enable it on > setup where it's not required we'll only annoy the memory controller with > less efficient access patterns. What I meant was, this value is still 0 in say, a system with 2 128MB DIMMs. > [...]
