On Wed, Dec 19, 2012 at 4:02 PM, Chris Wilson <chris at chris-wilson.co.uk> wrote: > On Wed, 19 Dec 2012 15:40:16 +0100, Daniel Vetter <daniel.vetter at ffwll.ch> wrote: >> The mmap offset structure is not part of the drm/i915 code, but >> provided by gem helpers. To avoid leaky abstractions (by either >> depending upon implementation details of said helper wrt to >> preallocations, or reimplementing it in our code and so fuzzing >> around in internal details of that helpr) simply disable >> the shrinker lock stealing accross calls into the helper functions. >> >> This should fix igt/gem_tiled_swapping. >> >> v2: Fix cleanup path confusion bemoaned by Chris Wilson. >> >> Reported-by: Mika Kuoppala <mika.kuoppala at linux.intel.com> >> Cc: Chris Wilson <chris at chris-wilson.co.uk> >> Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com> >> Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch> > > You can have a Reviewed-by for the flag, and a > This-works-but-I-do-not-think-it-addresses-the-bug for this kludge. Merged both - I agree that this here is not a beauty, but it removes a tricky dependency on the helper code while that one seems to be a bit in flux. Beating the helper code a bit into shape cane be done on top, and if we embed the drm_mm_node (as we should imo) all allocations disapper. So this patch here would then have no effect any longer and we could drop it again. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
