On Tue, 18 Dec 2012 01:28:22 +0100, Daniel Vetter <daniel at ffwll.ch> wrote: > The last parameter of search_free_generic is best_match, which isn't used > by any current caller. The only reason it's still there is that I haven't > converted yet all drm_mm.c users to preallocate drm_mm_node's, but as soon > as that's done best_match will die together with search_free_generic as a > public interface. > > So what's the atomic doing in here? I've looked through the drm/i915 > patches and couldn't see any reason ... Can we just respin the two i915 > patches with _generic and atomic = false dropped, or do I miss something > big here? It is scheduled to become a flags parameter for doing more funky searches. (Allocating preferrentially from unmappable for LLC/snoopable buffers etc) But the whole idea of the _generic functions is that they do no currying at all, otherwise we will eventually need a _generic_full. -Chris -- Chris Wilson, Intel Open Source Technology Centre
