Op 02-07-18 om 13:16 schreef Mahesh Kumar: > Now crc-core framework verifies the source string passed by the user. > So setting bad-source will fail. Expect file write to fail in bad-source > subtest of kms_pipe_crc_basic. > > Signed-off-by: Mahesh Kumar <mahesh1.kumar@xxxxxxxxx> > --- > tests/kms_pipe_crc_basic.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c > index 235fdc38..2d4dfee8 100644 > --- a/tests/kms_pipe_crc_basic.c > +++ b/tests/kms_pipe_crc_basic.c > @@ -48,8 +48,7 @@ static struct { > > static void test_bad_source(data_t *data) > { > - igt_assert(igt_sysfs_set(data->debugfs, "crtc-0/crc/control", "foo")); > - igt_assert(openat(data->debugfs, "crtc-0/crc/data", O_WRONLY) == -1); > + igt_assert(!igt_sysfs_set(data->debugfs, "crtc-0/crc/control", "foo")); > } > > #define N_CRCS 3 New behavior makes more sense. Reviewed-by: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx> Do you have igt commit rights? _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx