On Tue, 11 Dec 2012 00:07:45 +0100, Daniel Vetter <daniel.vetter at ffwll.ch> wrote: > We need to clean up the overlay first, before taking down the > stolen memory allocator. > > This regression has been introducec in > > commit 8040513870399f1cb032cb8bc805df5042fedcdf > Author: Chris Wilson <chris at chris-wilson.co.uk> > Date: Thu Nov 15 11:32:29 2012 +0000 > > drm/i915: Allocate overlay registers from stolen memory Time for a philosophical debate; I suggest the bug was latent and that the cleanup order was wrong originally. Here, we probably want to cleanup the overlay earlier, before we start tidying up the [pp]gtt etc. Also you want to move the drm_mm_takedown() into i915_gem_cleanup_stolen() for symmetry. -Chris -- Chris Wilson, Intel Open Source Technology Centre
