On Thu, Dec 6, 2012 at 3:54 PM, Chris Wilson <chris at chris-wilson.co.uk> wrote: > As the shrinker may be invoked for the allocation, and it may reap > neighbouring objects in the offset range mm, we need to be careful in > the order in which we allocate the node, search for free space and then > insert the node into the mmap offset range manager. > > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk> > Cc: Dave Airlie <airlied at redhat.com> > Cc: dri-devel at lists.freedesktop.org I think leaking allocation/shrinker details from drm/i915 like that into common (helper) code is a no-go. Which means we need to open-code create_mmap_offset in our code and add a big comment ... -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
