On Wed, 8 Aug 2012 23:35:32 +0200, Daniel Vetter <daniel.vetter at ffwll.ch> wrote: > Hi all, > > Essentially just rebase, with Ben's review comments taking into account and one > WARN_ON(mutex_is_locked) moved around a bit. > > Review&testing highly welcome. > > Cheers, Daniel > > Daniel Vetter (8): > drm/i915: properly guard ilk ips state > drm/i915: fixup up debugfs rps state handling > drm/i915: move all rps state into dev_priv->rps > drm/i915: kill dev_priv->mchdev_lock > drm/i915: DE_PCU_EVENT irq is ilk-only > drm/i915: fix up ilk drps/ips locking > drm/ips: move drps/ips/ilk related variables into dev_priv->ips 1-7 look like good mechanical changes to improve readability and remove some superstition (multiple igfx perchance). Only the single comment, Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk> > drm/i915: enable rc6 on ilk again Optimist. I think you need an ack from the guilty parties if they believe that the code is in good order first. -Chris -- Chris Wilson, Intel Open Source Technology Centre