On Wed, 8 Aug 2012 22:01:51 +0200, Daniel Vetter <daniel.vetter at ffwll.ch> wrote: > Handy for lazy people like me, or when people forget to add the output > of lspci -nn. > > v2: Chris Wilson noticed that we have this duplicated already in the > i915_capabilites debugfs file. But there \n as separator looks better, > which would be a bit verbose in dmesg. Abuse the preprocessor to > extract this all. > > Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch> I like the placement of the cpp magic next to the struct, that should make it easier to update both at the same time. I think I'd prefer the struct first, magic cpp second. And given the alternatives, I think this is the cleanest way to minimise the code duplication. Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk> -Chris -- Chris Wilson, Intel Open Source Technology Centre
