On Tue, Jul 31, 2012 at 03:35:01PM -0700, Eric Anholt wrote: > If a buffer that was the target of a PIPE_CONTROL from userland was a > reused one that hadn't been evicted which had not previously had this > workaround applied, then the early return for a correct > presumed_offset in this function meant we would not bind it into the > GTT and the write would land somewhere else. > > Fixes reproducible failures with GL_EXT_timer_query usage in apitrace, > and I also expect it to fix the intermittent OQ issues on snb that > danvet's been working on. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=48019 > Signed-off-by: Eric Anholt <eric at anholt.net> > Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk> > Reviewed-by: Carl Worth <cworth at cworth.org> > Tested-by: Carl Worth <cworth at cworth.org> Picked up for -fixes, thanks for the patch. I've also added a bz line for #52932 to the commit. I should have noticed this while banging against this particular wall, I guess I owe you a few beers for tracking it down ;-) Cheers, Daniel -- Daniel Vetter Mail: daniel at ffwll.ch Mobile: +41 (0)79 365 57 48
