On Thu, 26 Apr 2012 16:03:08 -0700, Ben Widawsky <ben at bwidawsk.net> wrote: > + mutex_unlock(&dev->struct_mutex); > + ret = __wait_seqno(ring, seqno, true, &timeout); > + drm_gem_object_unreference_unlocked(&obj->base); Once we have the seqno to wait on, we can drop the reference to the object. The reference to the ring will be persist whilst the device is open. Just saves doing an unsightly unlock/lock dance in the unref. -Chris -- Chris Wilson, Intel Open Source Technology Centre