Hi Uma, On 9 March 2018 at 18:17, Uma Shankar <uma.shankar@xxxxxxxxx> wrote: > Note: This is just to get a design feedback whether these interfaces > look ok. Based on community feedback on interfaces, we will implement > IGT tests to validate plane color features. This is un-tested currently. > Also, userspace implementation to use these properties is currently not > available. > A few suggestions as you get to writing the documentation/tests: - make it clear what the behaviour should be when userspace sets both plane and crtc degamma/gamma/ctm - add tests to ensure ^^ holds true Another small suggestion: - document color_mgmt_changed, and perhaps split it out out into a separate patch That said, things look ok, although others should also take a look. Emil _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
