On Tue, 24 Apr 2012 15:41:37 +0200, Daniel Vetter <daniel.vetter at ffwll.ch> wrote: > the only places we actually need the crtc timings is in the mode_set > function. > > So we can now safely rip out all the remaining calls to set_crtcinfo > left in the driver and clean up this confusion. I have a little flicker of doubt because these tend to end up being passed into the core drm as well as used during modeset. Even looking through the instances of drm_mode_set_crtcinfo() in the core, I'm left no the wiser as to which functions expect crtc_* to be filled in. As far I can see the only place where set_crtcinfo() must be called is prior to the final modeset, and so the crtc_* values are only ever used on the adjusted_mode. Hence why the drm usage leaves me slightly puzzled. -Chris -- Chris Wilson, Intel Open Source Technology Centre
