I think that ioctl to get GPU timestamp and its resolution would be the best approach. This ioctl won't be called very often so there's no need to sacrifice simplicity for performance in this case. Using clock_gettime() sounds like trouble to me. How would you keep GPU and CPU time synchronized? Is forcewakeup necessary in case of a register which is not affected by gfx reset? Regards, Jacek -----Original Message----- From: intel-gfx-bounces+jacek.lawrynowicz=intel.com at lists.freedesktop.org [mailto:intel-gfx-bounces+jacek.lawrynowicz=intel.com at lists.freedesktop.org] On Behalf Of Chris Wilson Sent: Wednesday, April 18, 2012 1:52 AM To: Ben Widawsky; Daniel Vetter Cc: intel-gfx at lists.freedesktop.org Subject: Re: TIMESTAMP register On Tue, 17 Apr 2012 16:27:45 -0700, Ben Widawsky <ben at bwidawsk.net> wrote: > On Tue, 17 Apr 2012 23:04:18 +0200 > Daniel Vetter <daniel at ffwll.ch> wrote: > > > On Tue, Apr 17, 2012 at 08:34:11PM +0000, Lawrynowicz, Jacek wrote: > > > ARB_timer_query allows client read TIMESTAMP both asynchronously and > > > synchronously. > > > The former can be implemented as you said but the latter requires > > > support from the KMD. > > > This must be a simple MMIO read as this is the only way to report > > > "current" GPU time. > > > Implementing synchronous TIMESTAMP query using pipe control would render > > > the third example from ARB_timer_query spec useless. > > > > Ok, I've looked like a dofus again, but now I've read the spec and > > we indeed seem to need a synchronous readout of the TIMESTAMP > > register. I guess a new register will do, together with some > > fixed-point integer that tells userspace how to convert it to nanoseconds. > > -Daniel > > I've not read the spec, but synchronous and "current" doesn't mean the > exact same thing to me. I assume the spec doesn't allow getting the > value in a batch and then just waiting for rendering to complete? The spec stipulates that the client is able to query the timestamp counter synchronously from within the render stream (ala PIPE_CONTROL) and query the current timestamp asynchronously. The spec also explicitly allows for those two clocks to be different (though close enough for the user to not care). Therefore you need only use the nanosecond monotonic clock for the asynchronous query and apply an offset to the GPU timestamp when converting that from ticks to nanoseconds. My bet is that clock_gettime() is going to beat even ioctl(QUERY_COUNTER), not least because TIMESTAMP (being a per-ring register) is going to require the forcewake dance. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx at lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/pkcs7-signature Size: 8658 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20120418/f801122f/attachment.bin> -------------- next part -------------- --------------------------------------------------------------------- Intel Technology Poland sp. z o.o. z siedziba w Gdansku ul. Slowackiego 173 80-298 Gdansk Sad Rejonowy Gdansk Polnoc w Gdansku, VII Wydzial Gospodarczy Krajowego Rejestru Sadowego, numer KRS 101882 NIP 957-07-52-316 Kapital zakladowy 200.000 zl This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
