On Tue, Apr 17, 2012 at 06:56:27AM -0300, Eugeni Dodonov wrote: > On Tue, Apr 17, 2012 at 05:57, Daniel Vetter <daniel at ffwll.ch> wrote: > > > On Mon, Apr 16, 2012 at 10:20:33PM -0300, Eugeni Dodonov wrote: > > > As Chris Wilson noticed, my previous patch that did the refactoring as > > one big > > > patch which moved everything at once was extremely difficult to review > > and > > > maintain. So I split the same refactoring into a series of smaller > > patches, > > > which move one subsystem at a time. > > > > Yeah, diffs are not actually readable, so looks like we have to do this > > piece-wise. > > > Please, tell me that you meant 'diffs are *now* actually readable' with a > 'not' being a typo instead of 'now' there by a chance... > > Because otherwise I couldn't understand what you meant with piece-wise. > Should I move each function at a time? :) Meh, type, diffs are _now_ readable ;-) > I'll do the intel_pm_init (or intel_init_pm) and send it on top of this > series. It makes lots of sense and will avoid exposing all those > platform-specific stuff where we won't need it except for initialization. Cool, I'll review the entire series in context of that additional patch then. -Daniel -- Daniel Vetter Mail: daniel at ffwll.ch Mobile: +41 (0)79 365 57 48
