On Fri, Apr 13, 2012 at 09:37:44PM -0300, Eugeni Dodonov wrote: > On Fri, Apr 13, 2012 at 18:17, Chris Wilson <chris at chris-wilson.co.uk>wrote: > > > We're starting to get to ridiculous levels of indention. Break the PCH > > detection of SDVO/HDMI outputs into its own routine, and perhaps further > > down in architectures? > > > > Yes, both intel_display and intel_hdmi get too overcomplex with those > patches :(. > > I haven't done the split in those series because I thought that the plan > was to land those VLV/HSW patches before doing the big display refactoring > we discussed some weeks ago. But I could certainly start doing it. > > Daniel, what do you think would best from your dinq maintainership point of > view - refactor those bits here and in other big patches of this series > (fdi and hdmi ones) and then resend all the patches; or have them as is and > do the big refactoring for everything after that? I this specific case I think we simply need to add an IS_HASWELL check before the HAS_PCH_SPLIT check - hsw shares zero output detection code in this block with previous pch_split chips, so the indentation seems to be pointless. -Daniel -- Daniel Vetter Mail: daniel at ffwll.ch Mobile: +41 (0)79 365 57 48
