On Sun, 15 Apr 2012 19:53:19 +0200, Daniel Vetter <daniel.vetter at ffwll.ch> wrote: > This regression has been introduced in > > commit ca9bfa7eed20ea34e862804e62aae10eb159edbb > Author: Daniel Vetter <daniel.vetter at ffwll.ch> > Date: Sat Jan 28 14:49:20 2012 +0100 > > drm/i915: fixup interlaced vertical timings confusion, part 1 > > Unfortunately that commit failed to take into account that the lvds > code does some special adjustements to the crtc timings for upscaling > an centering. > > Fix this by explicitly computing crtc timings in the lvds mode fixup > function and setting a special flag in mode->private_flags if the crtc > timings have been adjusted. > > v2: Add a comment to explain the new mode driver private flag, > suggested by Eugeni Dodonov. > > v3: Kill the confusing and now redundant set_crtcinfo call in > intel_fixed_panel_mode, noticed by Chris Wilson. > > Reported-and-Tested-by: Hans de Bruin <jmdebruin at xmsnet.nl> > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=43071 > Reviewed-by: Eugeni Dodonov <eugeni.dodonov at intel.com> > Signed-Off-by: Daniel Vetter <daniel.vetter at ffwll.ch> The patch fixes a regression and shouldn't have any side-effects as far as I can see, so Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk> Just wish there were more ponies. -Chris -- Chris Wilson, Intel Open Source Technology Centre
