On Sat, 14 Apr 2012 18:17:57 +0200, Daniel Vetter <daniel.vetter at ffwll.ch> wrote: > This regression has been introduced in > > commit ca9bfa7eed20ea34e862804e62aae10eb159edbb > Author: Daniel Vetter <daniel.vetter at ffwll.ch> > Date: Sat Jan 28 14:49:20 2012 +0100 > > drm/i915: fixup interlaced vertical timings confusion, part 1 > > Unfortunately that commit failed to take into account that the lvds > code does some special adjustements to the crtc timings for upscaling > an centering. > > Fix this by explicitly computing crtc timings in the lvds mode fixup > function and setting a special flag in mode->private_flags if the crtc > timings have been adjusted. Whilst the patch does what it says on the tin, I think this just underlines the fact that our handling of crtcinfo is just wrong and consists of fragile hacks. :( -Chris -- Chris Wilson, Intel Open Source Technology Centre
